Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1112853003: Apply automated fixits for Chrome clang plugin to chrome_elf. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
Reviewers:
Nico, Cait (Slow)
CC:
caitkp+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply automated fixits for Chrome clang plugin to chrome_elf. Working on trimming down plugin warnings on the Windows clang build. BUG=467287 TBR=caitkp@chromium.org Committed: https://crrev.com/b7da0dfb650c6b1ab86d9eba9362b944e20a2139 Cr-Commit-Position: refs/heads/master@{#327585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome_elf/blacklist/test/blacklist_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
5 years, 7 months ago (2015-04-29 18:53:20 UTC) #2
dcheng
+thakis
5 years, 7 months ago (2015-04-29 19:00:14 UTC) #4
Nico
lgtm
5 years, 7 months ago (2015-04-29 19:07:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112853003/1
5 years, 7 months ago (2015-04-29 19:11:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 21:50:49 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:52:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7da0dfb650c6b1ab86d9eba9362b944e20a2139
Cr-Commit-Position: refs/heads/master@{#327585}

Powered by Google App Engine
This is Rietveld 408576698