Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1112843002: [Android] Remove more uses of android_commands from build/android/pylib. (RELAND) (Closed)

Created:
5 years, 7 months ago by jbudorick
Modified:
5 years, 7 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, legend
Base URL:
https://chromium.googlesource.com/chromium/src.git@detriplicated
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove more uses of android_commands from build/android/pylib. (RELAND) BUG=267773, 482367, 482406 Committed: https://crrev.com/4551d0dcfd1712dbf665bc483e15e3ab3dba8e1a Cr-Commit-Position: refs/heads/master@{#327501}

Patch Set 1 : original: broke one of the host-driven tests #

Patch Set 2 : fixes for host-driven tests & specific device #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -81 lines) Patch
M build/android/PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/base/base_test_runner.py View 1 chunk +5 lines, -4 lines 0 comments Download
M build/android/pylib/base/test_dispatcher.py View 6 chunks +5 lines, -15 lines 0 comments Download
M build/android/pylib/base/test_dispatcher_unittest.py View 10 chunks +35 lines, -18 lines 0 comments Download
M build/android/pylib/device/adb_wrapper.py View 1 chunk +18 lines, -0 lines 0 comments Download
M build/android/pylib/device/battery_utils_test.py View 2 chunks +1 line, -3 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 1 2 chunks +24 lines, -1 line 0 comments Download
M build/android/pylib/device/device_utils_test.py View 2 chunks +67 lines, -8 lines 0 comments Download
M build/android/pylib/host_driven/test_case.py View 1 2 chunks +5 lines, -6 lines 0 comments Download
M build/android/pylib/host_driven/test_runner.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/perf/perf_control_unittest.py View 2 chunks +2 lines, -4 lines 0 comments Download
M build/android/pylib/perf/setup.py View 2 chunks +4 lines, -3 lines 0 comments Download
M build/android/pylib/utils/emulator.py View 3 chunks +6 lines, -7 lines 0 comments Download
M build/android/test_runner.py View 1 3 chunks +13 lines, -11 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
jbudorick
This is a reland of https://codereview.chromium.org/1105323002/ patchset 1 is the original patchset 2 is the ...
5 years, 7 months ago (2015-04-29 14:11:11 UTC) #2
perezju
lgtm w/nit https://codereview.chromium.org/1112843002/diff/20001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/1112843002/diff/20001/build/android/test_runner.py#newcode879 build/android/test_runner.py:879: nit: is than an extra empty line?
5 years, 7 months ago (2015-04-29 14:30:11 UTC) #3
jbudorick
https://codereview.chromium.org/1112843002/diff/20001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/1112843002/diff/20001/build/android/test_runner.py#newcode879 build/android/test_runner.py:879: On 2015/04/29 14:30:11, perezju wrote: > nit: is than ...
5 years, 7 months ago (2015-04-29 14:33:07 UTC) #4
jbudorick
+cc guanxian.li@intel FYI
5 years, 7 months ago (2015-04-29 14:45:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112843002/20001
5 years, 7 months ago (2015-04-29 16:02:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-29 16:07:12 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 16:07:59 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4551d0dcfd1712dbf665bc483e15e3ab3dba8e1a
Cr-Commit-Position: refs/heads/master@{#327501}

Powered by Google App Engine
This is Rietveld 408576698