Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1112833003: Straighten out SkPicture::AccelData APIs. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Straighten out SkPicture::AccelData APIs. Must have been we needed them to be weird (mutable, const setter) before. It doesn't look like that's necessary now... we can just pass it to the constructor. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2420e10d5a86da1964a05a749ab9bb625ae9f13e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -32 lines) Patch
M include/core/SkPicture.h View 4 chunks +5 lines, -8 lines 0 comments Download
M src/core/SkPicture.cpp View 2 chunks +10 lines, -9 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 2 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mtklein_C
5 years, 7 months ago (2015-04-29 14:24:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112833003/1
5 years, 7 months ago (2015-04-29 14:26:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-29 14:32:05 UTC) #6
reed1
api lgtm
5 years, 7 months ago (2015-04-29 14:58:28 UTC) #8
robertphillips
lgtm
5 years, 7 months ago (2015-04-29 15:15:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112833003/1
5 years, 7 months ago (2015-04-29 15:16:38 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 15:16:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2420e10d5a86da1964a05a749ab9bb625ae9f13e

Powered by Google App Engine
This is Rietveld 408576698