Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 111283007: Cap memory usage in path_create bench. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com, borenet
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Cap memory usage in path_create bench. Memory usage grows unbounded in path_create without this patch (growing the paths). This bench also somewhat needlessly cycles through 32 paths, so now we just work with one. Peak memory usage drops from ~2-3G to ~150M. This should fix the NexusS crashes, or at least get us to the next one. BUG=skia:1687 Committed: http://code.google.com/p/skia/source/detail?r=12925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M bench/PathBench.cpp View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 11 months ago (2014-01-06 19:00:38 UTC) #1
caryclark
lgtm
6 years, 11 months ago (2014-01-06 19:25:25 UTC) #2
mtklein
On 2014/01/06 19:25:25, caryclark wrote: > lgtm FYI, this does indeed make path_create finish quickly ...
6 years, 11 months ago (2014-01-06 19:26:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/111283007/1
6 years, 11 months ago (2014-01-06 19:27:14 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 20:19:16 UTC) #5
Message was sent while issue was closed.
Change committed as 12925

Powered by Google App Engine
This is Rietveld 408576698