Pass gfx structs by const ref (gfx::Vector2d/F)

Pass gfx structs by const ref (gfx::Vector2d/F)

Pass gfx structs by const ref (gfx::Vector2d/F)
Avoid unneccessary copy of structures gfx::Vector2d/F by passing them
by const ref rather than value. Any struct of size > 4 bytes should be
passed by const ref. Passing by ref for these structs is faster than
passing by value, especially when invoking function has multiple
parameters.

BUG=159273
Committed: https://crrev.com/b98996a2d5ad7a6f7164a1fb7121cb0b95840fe0
Cr-Commit-Position: refs/heads/master@{#328104}

[a.berwal, 2015-04-29 10:50:16]

a.berwal@samsung.com changed reviewers:
+ sadrul@chromium.org, sky@chromium.org

[a.berwal, 2015-04-29 10:50:17]

PTAL

[sadrul, 2015-04-29 15:09:53]

https://codereview.chromium.org/1112813003/diff/1/ui/events/gesture_detection...
File ui/events/gesture_detection/velocity_tracker_unittest.cc (right):

https://codereview.chromium.org/1112813003/diff/1/ui/events/gesture_detection...
ui/events/gesture_detection/velocity_tracker_unittest.cc:51: gfx::PointF p0,
This too?

https://codereview.chromium.org/1112813003/diff/1/ui/events/gesture_detection...
ui/events/gesture_detection/velocity_tracker_unittest.cc:60: gfx::PointF p0,
ditto

https://codereview.chromium.org/1112813003/diff/1/ui/events/gesture_detection...
ui/events/gesture_detection/velocity_tracker_unittest.cc:75: gfx::PointF p0,
ditto

https://codereview.chromium.org/1112813003/diff/1/ui/events/ozone/evdev/devic...
File ui/events/ozone/evdev/device_event_dispatcher_evdev.h (right):

https://codereview.chromium.org/1112813003/diff/1/ui/events/ozone/evdev/devic...
ui/events/ozone/evdev/device_event_dispatcher_evdev.h:83: const gfx::PointF
location,
This too?

[danakj, 2015-04-29 17:04:04]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-04-29 17:04:04]

ui/compositor LGTM

[a.berwal, 2015-04-30 03:14:08]

The CQ bit was checked by a.berwal@samsung.com

[commit-bot: I haz the power, 2015-04-30 03:14:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1112813003/1

[commit-bot: I haz the power, 2015-04-30 03:20:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-30 03:20:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[a.berwal, 2015-04-30 03:25:11]

https://chromiumcodereview.appspot.com/1112813003/diff/1/ui/events/gesture_de...
File ui/events/gesture_detection/velocity_tracker_unittest.cc (right):

https://chromiumcodereview.appspot.com/1112813003/diff/1/ui/events/gesture_de...
ui/events/gesture_detection/velocity_tracker_unittest.cc:51: gfx::PointF p0,
On 2015/04/29 15:09:53, sadrul wrote:
> This too?
For gfx::PointF i have uploaded seprate patch.

https://chromiumcodereview.appspot.com/1112813003/diff/1/ui/events/gesture_de...
ui/events/gesture_detection/velocity_tracker_unittest.cc:60: gfx::PointF p0,
On 2015/04/29 15:09:53, sadrul wrote:
> ditto
For gfx::PointF i have uploaded seprate patch.

https://chromiumcodereview.appspot.com/1112813003/diff/1/ui/events/gesture_de...
ui/events/gesture_detection/velocity_tracker_unittest.cc:75: gfx::PointF p0,
On 2015/04/29 15:09:53, sadrul wrote:
> ditto

For gfx::PointF i have uploaded seprate patch.

https://chromiumcodereview.appspot.com/1112813003/diff/1/ui/events/ozone/evde...
File ui/events/ozone/evdev/device_event_dispatcher_evdev.h (right):

https://chromiumcodereview.appspot.com/1112813003/diff/1/ui/events/ozone/evde...
ui/events/ozone/evdev/device_event_dispatcher_evdev.h:83: const gfx::PointF
location,
On 2015/04/29 15:09:53, sadrul wrote:
> This too?
For gfx::PointF i have uploaded seprate patch.

[a.berwal, 2015-04-30 04:12:21]

Can i TBR here?

[jdduke (slow), 2015-04-30 04:16:41]

On 2015/04/30 04:12:21, a.berwal wrote:
> Can i TBR here?

In general, no, unless it's urgent and/or a revert.

[a.berwal, 2015-04-30 04:18:45]

On 2015/04/30 04:16:41, jdduke wrote:
> On 2015/04/30 04:12:21, a.berwal wrote:
> > Can i TBR here?
> 
> In general, no, unless it's urgent and/or a revert.

ok

[sky, 2015-04-30 18:05:30]

LGTM

[a.berwal, 2015-05-04 03:00:01]

The CQ bit was checked by a.berwal@samsung.com

[commit-bot: I haz the power, 2015-05-04 03:00:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1112813003/1

[commit-bot: I haz the power, 2015-05-04 03:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-04 03:02:51]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[a.berwal, 2015-05-04 07:27:48]

The CQ bit was checked by a.berwal@samsung.com

[a.berwal, 2015-05-04 07:27:48]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
sky@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1112813003/#ps20001
(title: "Rebasing")

[commit-bot: I haz the power, 2015-05-04 07:27:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1112813003/20001

[commit-bot: I haz the power, 2015-05-04 08:28:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-04 08:29:38]

Patchset 2 (id:??) landed as
https://crrev.com/b98996a2d5ad7a6f7164a1fb7121cb0b95840fe0
Cr-Commit-Position: refs/heads/master@{#328104}