src/mips64/lithium-codegen-mips64.cc - Issue 1112793004: MIPS: Followup 'Fix Add HArrayBufferNotNeutered instruction'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips64/lithium-codegen-mips64.cc

Issue 1112793004: MIPS: Followup 'Fix Add HArrayBufferNotNeutered instruction'. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips64/lithium-codegen-mips64.cc

diff --git a/src/mips64/lithium-codegen-mips64.cc b/src/mips64/lithium-codegen-mips64.cc

index debaa28d86a4964e8d2564087fb245c6255285d9..340f57b94427a617bcc3ed2b3553efd14f167dca 100644

--- a/src/mips64/lithium-codegen-mips64.cc

+++ b/src/mips64/lithium-codegen-mips64.cc

@@ -5236,7 +5236,7 @@ void LCodeGen::DoCheckArrayBufferNotNeutered(

Label has_no_buffer;

__ ld(scratch, FieldMemOperand(view, JSArrayBufferView::kBufferOffset));

__ JumpIfSmi(scratch, &has_no_buffer);

- __ ld(scratch, FieldMemOperand(scratch, JSArrayBuffer::kBitFieldOffset));

+ __ lw(scratch, FieldMemOperand(scratch, JSArrayBuffer::kBitFieldOffset));

__ And(at, scratch, 1 << JSArrayBuffer::WasNeutered::kShift);

DeoptimizeIf(ne, instr, Deoptimizer::kOutOfBounds, at, Operand(zero_reg));

« no previous file with comments | « no previous file | no next file » | no next file with comments »