Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1112793002: Removing blink::prefix (Closed)

Created:
5 years, 7 months ago by a.berwal
Modified:
5 years, 7 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing blink::prefix Removing blink::prefix in Source/bindings/ whereever it is not needed. BUG=477256 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194655

Patch Set 1 #

Patch Set 2 : Fixing buildIssues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -69 lines) Patch
M Source/bindings/core/v8/CallbackPromiseAdapter.h View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptStreamer.cpp View 8 chunks +16 lines, -16 lines 0 comments Download
M Source/bindings/core/v8/ScriptStreamerThread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptStreamerThread.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8ScriptRunner.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/V8BindingForModules.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/V8BindingForModules.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8SVGTestInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestException.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface3.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceAccessors.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor2.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor3.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEmpty.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceOwnProperties.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceOwnPropertiesDerived.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
a.berwal
PTAL
5 years, 7 months ago (2015-04-29 09:10:53 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-29 11:36:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112793002/1
5 years, 7 months ago (2015-04-29 11:38:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/59824)
5 years, 7 months ago (2015-04-29 11:51:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112793002/20001
5 years, 7 months ago (2015-04-29 11:59:23 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 13:09:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194655

Powered by Google App Engine
This is Rietveld 408576698