Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Issue 1112773003: [Telemetry] Move TestStreamOutput to unittest_util. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
eakuefner, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Move TestStreamOutput to unittest_util. Motivation: when I make benchmark_runner._PrintBenchmarkList a public method, I want to provide unittest coverage for the method. I would want to reuse the logic of TestStreamOutput for writing that unittest. BUG=482090 Committed: https://crrev.com/3b678eae31007c956a67f507172be4f287725c95 Cr-Commit-Position: refs/heads/master@{#327610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M tools/telemetry/telemetry/results/base_test_results_unittest.py View 1 chunk +0 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest_util/gtest_progress_reporter_unittest.py View 3 chunks +2 lines, -16 lines 0 comments Download
A tools/telemetry/telemetry/unittest_util/stream.py View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
5 years, 7 months ago (2015-04-29 16:49:49 UTC) #2
eakuefner
lgtm
5 years, 7 months ago (2015-04-29 23:10:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112773003/1
5 years, 7 months ago (2015-04-29 23:14:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 23:20:44 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 23:21:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b678eae31007c956a67f507172be4f287725c95
Cr-Commit-Position: refs/heads/master@{#327610}

Powered by Google App Engine
This is Rietveld 408576698