Issue 1112753003: win: prefer amd64_x86 compiler on >= 2013, not just 2013

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1112753003: win: prefer amd64_x86 compiler on >= 2013, not just 2013 (Closed)

Created:
5 years, 7 months ago by scottmg

Modified:
5 years, 7 months ago

Reviewers:
Dirk Pranke, Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Target Ref:
refs/heads/master

Project:
gyp

Visibility:
Public.

win: prefer amd64_x86 compiler on >= 2013, not just 2013 [[ Because I always find binary string ops a bit odd: >>> '2003' >= '2013' False >>> '2005' >= '2013' False >>> '2008' >= '2013' False >>> '2010' >= '2013' False >>> '2012' >= '2013' False >>> '2013' >= '2013' True >>> '2015' >= '2013' True >>> '2017' >= '2013' True >>> '2090' >= '2013' True ]] R=dpranke@chromium.org, thakis@chromium.org BUG=chromium:482238 Committed: https://chromium.googlesource.com/external/gyp/+/8866260996c063f514dfafd0e05743a42709a49c

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	pylib/gyp/MSVSVersion.py	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

scottmg

5 years, 7 months ago (2015-04-29 00:40:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8866260996c063f514dfafd0e05743a42709a49c.