Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1112753002: mac: Bump the deployment target of gcapi to 10.5. (Closed)

Created:
5 years, 7 months ago by erikchen
Modified:
5 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Bump the deployment target of gcapi_lib to 10.5. The code requires methods only present on 10.5+, so having a deployment target of 10.4 is incorrect. BUG=471823 Committed: https://crrev.com/0c6438b2b6510c19903d99bea882efa3c1f8564e Cr-Commit-Position: refs/heads/master@{#327543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/chrome_installer.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
erikchen
mark: Please review.
5 years, 7 months ago (2015-04-29 00:12:29 UTC) #2
Mark Mentovai
What does it require that’s 10.5-only? I think we set this at 10.4 because someone ...
5 years, 7 months ago (2015-04-29 00:38:39 UTC) #3
erikchen
On 2015/04/29 00:38:39, Mark Mentovai wrote: > What does it require that’s 10.5-only? I think ...
5 years, 7 months ago (2015-04-29 17:59:49 UTC) #4
Mark Mentovai
Well then LGTM for sure.
5 years, 7 months ago (2015-04-29 18:00:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112753002/1
5 years, 7 months ago (2015-04-29 18:02:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 19:19:50 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 19:20:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c6438b2b6510c19903d99bea882efa3c1f8564e
Cr-Commit-Position: refs/heads/master@{#327543}

Powered by Google App Engine
This is Rietveld 408576698