NSSCertDatabaseChromeOS

net/cert/cert_database.h

Index: net/cert/cert_database.h
diff --git a/net/cert/cert_database.h b/net/cert/cert_database.h
index feadf4c1d0856d8795cc9f0690fd84000414e090..ccb037c68d4ae353d4aede10c634c9fe2bfe63b0 100644
--- a/net/cert/cert_database.h
+++ b/net/cert/cert_database.h
@@ -16,6 +16,8 @@ template <class ObserverType> class ObserverListThreadSafe;
 
 namespace net {
 
+class NSSCertDatabase;
+
 // This class provides cross-platform functions to verify and add user
 // certificates, and to observe changes to the underlying certificate stores.
 
@@ -85,6 +87,12 @@ class NET_EXPORT CertDatabase {
   void OnAndroidKeyChainChanged();
 #endif
 
+#if defined(USE_NSS)
+  // Observe events from the |source| and forward them to observers of this
+  // CertDatabase.
+  void AddSource(NSSCertDatabase* source);

[Ryan Sleevi, 2013/12/13 19:16:59]

Naming wise, I think this is fairly ambiguous.

Perhaps

ObserveNSSCertDatabase() ?

That said, I'm having trouble understanding why there isn't a 1:1 relationship
between NSSCertDatabase and CertDatabase here. When would one have a CertDB
observing multiple (distinct) NSS CertDBs?

[mattm, 2013/12/14 00:41:08]

Since NSSCertDatabaseChromeOS subclasses NSSCertDatabase, and there can be
multiple NSSCertDatabaseChromeOS.  (Also there still exists the instance of the
non-subclassed NSSCertDatabase for all the existing users of
NSSCertDatabase::GetInstance() which still need to be updated.)

[mattm, 2013/12/18 04:00:50]

done.

+#endif
+
  private:
   friend struct DefaultSingletonTraits<CertDatabase>;