Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 1112693003: Apply automated fixits for Chrome clang plugin to ui. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
Reviewers:
Nico
CC:
aboxhall+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie(Not used), nektar+watch_chromium.org, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply automated fixits for Chrome clang plugin to ui. Working on trimming down plugin warnings on the Windows clang build. BUG=467287 Committed: https://crrev.com/629e82aeca73dd6be98800f7e8d9599faf9c3725 Cr-Commit-Position: refs/heads/master@{#327549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/accessibility/platform/ax_platform_node_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 7 months ago (2015-04-29 18:57:17 UTC) #2
Nico
lgtm
5 years, 7 months ago (2015-04-29 19:04:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112693003/1
5 years, 7 months ago (2015-04-29 19:08:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 19:36:32 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 19:38:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/629e82aeca73dd6be98800f7e8d9599faf9c3725
Cr-Commit-Position: refs/heads/master@{#327549}

Powered by Google App Engine
This is Rietveld 408576698