Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator.cc

Issue 1112693002: [Extensions] Fix use-after-free in the developer private API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/developer_private/extension_info_generator.cc
diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
index fd91759ec21c43cfb965ff5b1b490047d011d50b..0d1ddcbd241d7be7f303051e2b7b6f8779eb89e5 100644
--- a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
@@ -508,12 +508,13 @@ void ExtensionInfoGenerator::OnImageLoaded(
--pending_image_loads_;
if (pending_image_loads_ == 0) { // All done!
- // We assign to a temporary and Reset() so that at the end of the method,
- // any stored refs are destroyed.
+ // We assign to a temporary callback and list and reset the stored values so
+ // that at the end of the method, any stored refs are destroyed.
+ ExtensionInfoList list;
+ list.swap(list_);
ExtensionInfosCallback callback = callback_;
callback_.Reset();
- callback.Run(list_);
- list_.clear();
+ callback.Run(list); // WARNING: |this| is possibly deleted after this line!
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698