Issue 1112673002: Revert "Make CFX_WideString::LockBuffer() completely unused."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1112673002: Revert "Make CFX_WideString::LockBuffer() completely unused." (Closed)

Created:
5 years, 7 months ago by Tom Sepez

Modified:
5 years, 7 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Make CFX_WideString::LockBuffer() completely unused." This reverts commit 5a256ad29483eb2b13e6e2c89fe0f77a9103f68f. Reason for revert: broke JS tests. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0334cb31d20bc896ce649da55489e8e7348111f8

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -13 lines)			Patch
M	core/include/fxcrt/fx_string.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	core/src/fpdfdoc/doc_bookmark.cpp	View	2 chunks	+6 lines, -13 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_bstring.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_wstring.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Tom Sepez

5 years, 7 months ago (2015-04-28 19:34:00 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0334cb31d20bc896ce649da55489e8e7348111f8 (tree was closed).