Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1112643004: Hide the autofill keyboard accessory when the keyboard hides. (Closed)

Created:
5 years, 7 months ago by Evan Stade
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide the autofill keyboard accessory when the keyboard hides. Doing this requires adding a new listener interface on WindowAndroid. BUG=428087 Committed: https://crrev.com/046946e55ca6b8c66f839cafc210f6d3b1f3a2ad Cr-Commit-Position: refs/heads/master@{#327407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java View 3 chunks +12 lines, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/base/WindowAndroid.java View 3 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
5 years, 7 months ago (2015-04-28 22:24:35 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 7 months ago (2015-04-28 22:34:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112643004/1
5 years, 7 months ago (2015-04-28 22:39:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 01:06:23 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 01:07:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/046946e55ca6b8c66f839cafc210f6d3b1f3a2ad
Cr-Commit-Position: refs/heads/master@{#327407}

Powered by Google App Engine
This is Rietveld 408576698