Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: Source/core/rendering/RenderTable.cpp

Issue 111263002: Merge 163220 "Should paint border before background when bleedAv..." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/1700/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderTable.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 713 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 void RenderTable::paintBoxDecorations(PaintInfo& paintInfo, const LayoutPoint& p aintOffset) 724 void RenderTable::paintBoxDecorations(PaintInfo& paintInfo, const LayoutPoint& p aintOffset)
725 { 725 {
726 if (!paintInfo.shouldPaintWithinRoot(this)) 726 if (!paintInfo.shouldPaintWithinRoot(this))
727 return; 727 return;
728 728
729 LayoutRect rect(paintOffset, size()); 729 LayoutRect rect(paintOffset, size());
730 subtractCaptionRect(rect); 730 subtractCaptionRect(rect);
731 paintBoxDecorationsWithRect(paintInfo, paintOffset, rect); 731 paintBoxDecorationsWithRect(paintInfo, paintOffset, rect);
732 } 732 }
733 733
734 void RenderTable::paintBackgroundWithBorderAndBoxShadow(PaintInfo& paintInfo, co nst LayoutRect& rect, BackgroundBleedAvoidance bleedAvoidance)
735 {
736 paintBackground(paintInfo, rect, bleedAvoidance);
737 paintBoxShadow(paintInfo, rect, style(), Inset);
738
739 if (bleedAvoidance != BackgroundBleedBackgroundOverBorder && !style()->hasAp pearance() && style()->hasBorder() && !collapseBorders())
740 paintBorder(paintInfo, rect, style());
741 }
742
743 void RenderTable::paintMask(PaintInfo& paintInfo, const LayoutPoint& paintOffset ) 734 void RenderTable::paintMask(PaintInfo& paintInfo, const LayoutPoint& paintOffset )
744 { 735 {
745 if (style()->visibility() != VISIBLE || paintInfo.phase != PaintPhaseMask) 736 if (style()->visibility() != VISIBLE || paintInfo.phase != PaintPhaseMask)
746 return; 737 return;
747 738
748 LayoutRect rect(paintOffset, size()); 739 LayoutRect rect(paintOffset, size());
749 subtractCaptionRect(rect); 740 subtractCaptionRect(rect);
750 741
751 paintMaskImages(paintInfo, rect); 742 paintMaskImages(paintInfo, rect);
752 } 743 }
(...skipping 693 matching lines...) Expand 10 before | Expand all | Expand 10 after
1446 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const 1437 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const
1447 { 1438 {
1448 ASSERT(cell->isFirstOrLastCellInRow()); 1439 ASSERT(cell->isFirstOrLastCellInRow());
1449 if (hasSameDirectionAs(cell->row())) 1440 if (hasSameDirectionAs(cell->row()))
1450 return style()->borderEnd(); 1441 return style()->borderEnd();
1451 1442
1452 return style()->borderStart(); 1443 return style()->borderStart();
1453 } 1444 }
1454 1445
1455 } 1446 }
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTable.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698