Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1112623002: Eliminate component/update_client dependency on content/ (Closed)

Created:
5 years, 7 months ago by Sorin Jianu
Modified:
5 years, 7 months ago
Reviewers:
waffles, blundell
CC:
chromium-reviews, jam, blundell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate component/update_client dependency on content/ BUG=479904 Committed: https://crrev.com/f9f4834d3690715c918eaaea589f18472e95ebd9 Cr-Commit-Position: refs/heads/master@{#327311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -47 lines) Patch
M components/update_client/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
M components/update_client/update_client_unittest.cc View 14 chunks +42 lines, -38 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sorin Jianu
As promised, the dependency on content is removed.
5 years, 7 months ago (2015-04-28 16:34:14 UTC) #3
waffles
lgtm
5 years, 7 months ago (2015-04-28 16:41:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112623002/1
5 years, 7 months ago (2015-04-28 17:04:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 17:15:10 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f9f4834d3690715c918eaaea589f18472e95ebd9 Cr-Commit-Position: refs/heads/master@{#327311}
5 years, 7 months ago (2015-04-28 17:15:57 UTC) #8
blundell
5 years, 7 months ago (2015-04-29 08:37:43 UTC) #10
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698