Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1112603003: mojo: Fix html_viewer build break from https://codereview.chromium.org/1115443002 (Closed)

Created:
5 years, 7 months ago by Sami
Modified:
5 years, 7 months ago
Reviewers:
msw, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Fix html_viewer build break from https://codereview.chromium.org/1115443002 TBR=sky@chromium.org Committed: https://crrev.com/e6e4db76045d288250869cb81bc92e2cce64ebae Cr-Commit-Position: refs/heads/master@{#327347}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/html_viewer/blink_platform_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
Sami
PTAL.
5 years, 7 months ago (2015-04-28 17:40:58 UTC) #2
msw
https://codereview.chromium.org/1112603003/diff/1/components/html_viewer/blink_platform_impl.cc File components/html_viewer/blink_platform_impl.cc (right): https://codereview.chromium.org/1112603003/diff/1/components/html_viewer/blink_platform_impl.cc#newcode266 components/html_viewer/blink_platform_impl.cc:266: base::MessageLoopProxy::current(); This file might need an explicit base/message_loop/message_loop.h include.
5 years, 7 months ago (2015-04-28 17:50:11 UTC) #4
msw
lgtm
5 years, 7 months ago (2015-04-28 18:13:35 UTC) #5
Sami
Thanks, TBRing to fix the build.
5 years, 7 months ago (2015-04-28 18:20:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112603003/1
5 years, 7 months ago (2015-04-28 18:22:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 19:19:45 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 19:20:49 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e6e4db76045d288250869cb81bc92e2cce64ebae
Cr-Commit-Position: refs/heads/master@{#327347}

Powered by Google App Engine
This is Rietveld 408576698