Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1112603002: Add new GM/bench for line-only convex paths (Closed)

Created:
5 years, 7 months ago by robertphillips
Modified:
5 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add new GM/bench for line-only convex paths BUG=472723 Committed: https://skia.googlesource.com/skia/+/7272935744670aebf82699c2f91aaff3cd4c3172

Patch Set 1 #

Patch Set 2 : Fix SK_ARRAY_COUNT issue #

Patch Set 3 : Fix another SK_ARRAY_COUNT issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -0 lines) Patch
A gm/convex_all_line_paths.cpp View 1 2 1 chunk +321 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
robertphillips
5 years, 7 months ago (2015-04-28 14:10:03 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112603002/1
5 years, 7 months ago (2015-04-28 14:10:18 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/702) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
5 years, 7 months ago (2015-04-28 14:16:02 UTC) #6
bsalomon
lgtm. minor suggestion to rename convexalllinepaths.cpp to convex_all_line_paths.cpp. It took me a moment to parse ...
5 years, 7 months ago (2015-04-28 14:24:46 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112603002/20001
5 years, 7 months ago (2015-04-28 14:30:16 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/727)
5 years, 7 months ago (2015-04-28 14:33:33 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112603002/40001
5 years, 7 months ago (2015-04-28 14:36:14 UTC) #15
robertphillips
On 2015/04/28 14:24:46, bsalomon wrote: > lgtm. > > minor suggestion to rename convexalllinepaths.cpp to ...
5 years, 7 months ago (2015-04-28 14:39:58 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-28 14:41:29 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112603002/40001
5 years, 7 months ago (2015-04-28 14:41:47 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 14:42:07 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7272935744670aebf82699c2f91aaff3cd4c3172

Powered by Google App Engine
This is Rietveld 408576698