Issue 1112593002: [New Multicolumn] Spanners are not part of the nearest ancestor flow thread.

Issue 1112593002: [New Multicolumn] Spanners are not part of the nearest ancestor flow thread. (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)

Modified:
5 years, 7 months ago

Reviewers:
dsinclair, chrishtr, Julien - ping for review

CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, mstensho (USE GERRIT), slimming-paint-reviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

[New Multicolumn] Spanners are not part of the nearest ancestor flow thread. Cannot take the fast path when calculating the enclosing pagination layer of a spanner. Need to examine the containing block chain, just like we do when there are out-of-flow objects. BUG=481663, 481926 R=chrishtr@chromium.org,dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194607

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -7 lines)			Patch
A	LayoutTests/fast/multicol/span/as-inner-multicol.html	View	1 chunk	+14 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/multicol/span/as-inner-multicol-after-composited-layer-crash-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/multicol/span/as-inner-multicol-expected.html	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	Source/core/paint/DeprecatedPaintLayer.cpp	View	1 chunk	+12 lines, -7 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112593002/1

5 years, 7 months ago (2015-04-28 15:21:23 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194607

5 years, 7 months ago (2015-04-28 15:24:33 UTC) #5

mstensho (USE GERRIT)

5 years, 7 months ago (2015-04-28 19:40:36 UTC) #6

Message was sent while issue was closed.

@dsinclair: Thank you very much for ultra-fast reviews! :)