Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1112583004: Enable BlockingLoginTest, ForceMaximizeOnFirstRunTest, UserCloudPolicyManagerTest, for webview. (Closed)

Created:
5 years, 7 months ago by achuithb
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@policy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable BlockingLoginTest, ForceMaximizeOnFirstRunTest, UserCloudPolicyManagerTest, for webview. The code here is from Dmitry's CL: https://codereview.chromium.org/1107873002/#ps1 And Nikita's CL: https://codereview.chromium.org/1052683006/ BUG=475567, 477402 Committed: https://crrev.com/8c52ec023857ec7d082d54518864edd84d25b116 Cr-Commit-Position: refs/heads/master@{#327435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -67 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +17 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 5 chunks +40 lines, -36 lines 0 comments Download
M chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc View 6 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M chromeos/login/auth/auth_status_consumer.h View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
achuithb
This is just a rollup of Nikita and Dmitry's CLs.
5 years, 7 months ago (2015-04-28 22:15:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112583004/1
5 years, 7 months ago (2015-04-28 22:22:33 UTC) #4
xiyuan
lgtm
5 years, 7 months ago (2015-04-28 22:25:47 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-29 00:39:12 UTC) #7
Nikita (slow)
lgtm
5 years, 7 months ago (2015-04-29 04:54:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112583004/1
5 years, 7 months ago (2015-04-29 04:54:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 04:56:37 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 04:57:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c52ec023857ec7d082d54518864edd84d25b116
Cr-Commit-Position: refs/heads/master@{#327435}

Powered by Google App Engine
This is Rietveld 408576698