Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: pkg/compiler/lib/src/resolution/send_structure.dart

Issue 1112563002: Refactor SsaBuilder.visitStaticSend and visitGetterSend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/send_resolver.dart ('k') | pkg/compiler/lib/src/resolved_visitor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/send_structure.dart
diff --git a/pkg/compiler/lib/src/resolution/send_structure.dart b/pkg/compiler/lib/src/resolution/send_structure.dart
index 2854f330e2be99ad1c11d5e352dcd9ae5bab0d69..23c4d862b9a7d0a221afa20606934189d3ffab79 100644
--- a/pkg/compiler/lib/src/resolution/send_structure.dart
+++ b/pkg/compiler/lib/src/resolution/send_structure.dart
@@ -333,7 +333,7 @@ class InvokeStructure<R, A> implements SendStructure<R, A> {
callStructure,
arg);
case AccessKind.UNRESOLVED:
- return visitor.errorUnresolvedInvoke(
+ return visitor.visitUnresolvedInvoke(
node,
semantics.element,
node.argumentsNode,
@@ -374,6 +374,13 @@ class IncompatibleInvokeStructure<R, A> implements SendStructure<R, A> {
R dispatch(SemanticSendVisitor<R, A> visitor, Send node, A arg) {
switch (semantics.kind) {
+ case AccessKind.STATIC_METHOD:
+ return visitor.visitStaticFunctionIncompatibleInvoke(
+ node,
+ semantics.element,
+ node.argumentsNode,
+ callStructure,
+ arg);
case AccessKind.SUPER_METHOD:
return visitor.visitSuperMethodIncompatibleInvoke(
node,
@@ -381,7 +388,14 @@ class IncompatibleInvokeStructure<R, A> implements SendStructure<R, A> {
node.argumentsNode,
callStructure,
arg);
- default:
+ case AccessKind.TOPLEVEL_METHOD:
+ return visitor.visitTopLevelFunctionIncompatibleInvoke(
+ node,
+ semantics.element,
+ node.argumentsNode,
+ callStructure,
+ arg);
+ default:
// TODO(johnniwinther): Support more variants of this invoke structure.
break;
}
@@ -522,7 +536,7 @@ class GetStructure<R, A> implements SendStructure<R, A> {
semantics.constant,
arg);
case AccessKind.UNRESOLVED:
- return visitor.errorUnresolvedGet(
+ return visitor.visitUnresolvedGet(
node,
semantics.element,
arg);
« no previous file with comments | « pkg/compiler/lib/src/resolution/send_resolver.dart ('k') | pkg/compiler/lib/src/resolved_visitor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698