Issue 1112513004: Clean up CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1112513004: Clean up CSSPropertyParser (Closed)

Created:
5 years, 7 months ago by rwlbuis

Modified:
5 years, 7 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Clean up CSSPropertyParser Clean up CSSPropertyParser by: - removing the !id checks before calling validUnit. We do this inconsistently so better take one approach. Since invalid CSS properties should be the exception, I'd expect this way to be more efficient. - group some CSS properties that end up calling the same code. BUG=404023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194639

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -43 lines)			Patch
	M	Source/core/css/parser/CSSPropertyParser.cpp	View	1 2	19 chunks	+25 lines, -43 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112513004/60001

5 years, 7 months ago (2015-04-29 00:17:06 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-04-29 01:35:17 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194639

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1112513004: Clean up CSSPropertyParser (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix some errors #

Patch Set 3 : Add some SVG props to the fun #

Messages