Put Data Reduction Proxy support in Cronet behind a gyp flag

Put Data Reduction Proxy support in Cronet behind a gyp flag

Compile the Data Reduction Proxy into Cronet only if the gyp
variable enable_data_reduction_proxy_support is set to 1.
By default, it is set to 0.

BUG=461910
Committed: https://crrev.com/319828dc0983cac3a7c77eb9dc1fdf6c4bf1e569
Cr-Commit-Position: refs/heads/master@{#330021}

[bengr, 2015-04-28 22:34:37]

Patchset #1 (id:1) has been deleted

[bengr, 2015-04-28 22:38:21]

Patchset #1 (id:20001) has been deleted

[bengr, 2015-04-28 22:38:52]

bengr@chromium.org changed reviewers:
+ mef@chromium.org

[bengr, 2015-04-28 22:38:53]

PTAL.

[mef, 2015-05-13 18:21:25]

https://codereview.chromium.org/1112513003/diff/40001/components/cronet.gypi
File components/cronet.gypi (right):

https://codereview.chromium.org/1112513003/diff/40001/components/cronet.gypi#...
components/cronet.gypi:123: 'DATA_REDUCTION_PROXY_SUPPORT'
would it make sense to have =1?

https://codereview.chromium.org/1112513003/diff/40001/components/cronet.gypi#...
components/cronet.gypi:144: 'variables': {
should this whole section (except dependencies) go into 'cronet_static.gypi'?

https://codereview.chromium.org/1112513003/diff/40001/components/cronet/andro...
File components/cronet/android/test/native_test_server.cc (right):

https://codereview.chromium.org/1112513003/diff/40001/components/cronet/andro...
components/cronet/android/test/native_test_server.cc:157: return true;
JNI_TRUE

https://codereview.chromium.org/1112513003/diff/40001/components/cronet/andro...
components/cronet/android/test/native_test_server.cc:159: return false;
JNI_FALSE

[xunjieli, 2015-05-14 14:24:09]

xunjieli@chromium.org changed reviewers:
+ xunjieli@chromium.org

[xunjieli, 2015-05-14 14:24:10]

https://codereview.chromium.org/1112513003/diff/40001/components/cronet/andro...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
(right):

https://codereview.chromium.org/1112513003/diff/40001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java:122:
mActivity.mUrlRequestContext.shutdown();
The first context is useless right?
Can we instead do sth like,
System.loadLibrary("cronet_tests");
if (!NativeTestServer.isDataReductionProxySupported()) {
    return;
}

mActivity = launchCronetTestAppWithUrlAndCommandLineArgs(null,commandLineArgs);
// with config2

to avoid creating the first context?

[bengr, 2015-05-15 00:54:55]

https://codereview.chromium.org/1112513003/diff/40001/components/cronet.gypi
File components/cronet.gypi (right):

https://codereview.chromium.org/1112513003/diff/40001/components/cronet.gypi#...
components/cronet.gypi:123: 'DATA_REDUCTION_PROXY_SUPPORT'
On 2015/05/13 18:21:24, mef wrote:
> would it make sense to have =1?

I considered that, but didn't see an advantage.

https://codereview.chromium.org/1112513003/diff/40001/components/cronet.gypi#...
components/cronet.gypi:144: 'variables': {
On 2015/05/13 18:21:24, mef wrote:
> should this whole section (except dependencies) go into 'cronet_static.gypi'?

Done.

https://codereview.chromium.org/1112513003/diff/40001/components/cronet/andro...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
(right):

https://codereview.chromium.org/1112513003/diff/40001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java:122:
mActivity.mUrlRequestContext.shutdown();
On 2015/05/14 14:24:10, xunjieli wrote:
> The first context is useless right?
> Can we instead do sth like,
> System.loadLibrary("cronet_tests");
> if (!NativeTestServer.isDataReductionProxySupported()) {
>     return;
> }
> 
> mActivity =
launchCronetTestAppWithUrlAndCommandLineArgs(null,commandLineArgs);
> // with config2
> 
> to avoid creating the first context?

Fixed in a CL that landed recently.

https://codereview.chromium.org/1112513003/diff/40001/components/cronet/andro...
File components/cronet/android/test/native_test_server.cc (right):

https://codereview.chromium.org/1112513003/diff/40001/components/cronet/andro...
components/cronet/android/test/native_test_server.cc:157: return true;
On 2015/05/13 18:21:24, mef wrote:
> JNI_TRUE

Done.

https://codereview.chromium.org/1112513003/diff/40001/components/cronet/andro...
components/cronet/android/test/native_test_server.cc:159: return false;
On 2015/05/13 18:21:25, mef wrote:
> JNI_FALSE

Done.

[mef, 2015-05-15 01:25:46]

lgtm

I wish we could conditionally include / exclude java files for test project, so
we would extract DRP test into separate file and avoid hacking nativeTestServer,
but I don't see any examples of this anywhere.

[bengr, 2015-05-15 01:38:49]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2015-05-15 01:39:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1112513003/60001

[commit-bot: I haz the power, 2015-05-15 02:07:06]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-05-15 02:07:59]

Patchset 2 (id:??) landed as
https://crrev.com/319828dc0983cac3a7c77eb9dc1fdf6c4bf1e569
Cr-Commit-Position: refs/heads/master@{#330021}