Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: content/renderer/render_frame_impl.h

Issue 1112513002: PlzNavigate: unify OnCommitNavigation with OnNavigate in RenderFrameImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-browsertests
Patch Set: Addressed comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 5c4c0589cdbb807b966b99667677a288888d5739..c2b35d1b33a1123385c01b77867c19d4d26117e4 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -112,6 +112,7 @@ struct NavigationParams;
struct RequestNavigationParams;
struct ResourceResponseHead;
struct StartNavigationParams;
+struct StreamOverrideParameters;
class CONTENT_EXPORT RenderFrameImpl
: public RenderFrame,
@@ -666,6 +667,19 @@ class CONTENT_EXPORT RenderFrameImpl
const Referrer& referrer,
blink::WebNavigationPolicy policy);
+ // Performs a navigation in the frame. This provides a unified function for
+ // the current code path and the browser-side navigation path (in
+ // development). Currently used by OnNavigate, with all *NavigationParams
+ // provided by the browser. |stream_params| should be null.
+ // PlzNavigate: used by OnCommitNavigation, with |common_params| and
+ // |request_params| received by the browser. |stream_params| should be non
+ // null and created from the information provided by the browser.
+ // |start_params| is not used.
+ void NavigateInternal(const CommonNavigationParams& common_params,
+ const StartNavigationParams& start_params,
+ const RequestNavigationParams& request_params,
+ scoped_ptr<StreamOverrideParameters> stream_params);
+
// Update current main frame's encoding and send it to browser window.
// Since we want to let users see the right encoding info from menu
// before finishing loading, we call the UpdateEncoding in
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698