Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1112503002: Turn JSArrayBuffer::flags into a bit field (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn JSArrayBuffer::flags into a bit field That way, we can access it more easily without all the smi magic BUG=none R=dcarney@chromium.org LOG=n Committed: https://crrev.com/1630253f937f200bd67c05d39d503ba1144440cb Cr-Commit-Position: refs/heads/master@{#28098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -28 lines) Patch
M src/hydrogen.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +8 lines, -9 lines 0 comments Download
M src/objects-inl.h View 1 chunk +20 lines, -12 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-04-28 09:15:05 UTC) #1
dcarney
lgtm
5 years, 7 months ago (2015-04-28 09:22:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112503002/1
5 years, 7 months ago (2015-04-28 09:22:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 09:40:39 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 09:40:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1630253f937f200bd67c05d39d503ba1144440cb
Cr-Commit-Position: refs/heads/master@{#28098}

Powered by Google App Engine
This is Rietveld 408576698