Add a flag to the compiler for compiling polymer code.

third_party/closure_compiler/compile.py

 #!/usr/bin/python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Closure compiler on JavaScript files to check for errors and produce
 minified output."""
 
 import argparse
 import os
 import re
 import subprocess
 import sys
 import tempfile
 
 import build.inputs
 import processor
 import error_filter
 

[Dan Beam, 2015/05/12 04:55:55]

extra \n (\n\n between file-level globals)

[Jeremy Klein, 2015/05/12 05:46:07]

Done.

+_CURRENT_DIR = os.path.join(os.path.dirname(__file__))
+
 
 class Checker(object):
   """Runs the Closure compiler on given source files to typecheck them
   and produce minified output."""
 
+  _COMMON_JSCOMP_ERRORS = [
+    "accessControls",
+    "ambiguousFunctionDecl",
+    "checkStructDictInheritance",
+    "checkTypes",
+    "checkVars",
+    "constantProperty",
+    "deprecated",
+    "externsValidation",
+    "globalThis",
+    "invalidCasts",
+    "missingProperties",
+    "missingReturn",
+    "nonStandardJsDocs",
+    "suspiciousCode",
+    "undefinedNames",
+    "undefinedVars",
+    "unknownDefines",
+    "uselessCode",
+    "visibility",
+  ]
+
+  # Extra @jsDocAnnotations used when compiling polymer code.
+  _POLYMER_EXTRA_ANNOTATIONS = [
+    "attribute",
+    "status",
+    "element",
+    "homepage",
+    "submodule",
+    "group",
+  ]
+
   _COMMON_CLOSURE_ARGS = [
     "--accept_const_keyword",
-    "--jscomp_error=accessControls",
-    "--jscomp_error=ambiguousFunctionDecl",
-    "--jscomp_error=checkStructDictInheritance",
-    "--jscomp_error=checkTypes",
-    "--jscomp_error=checkVars",
-    "--jscomp_error=constantProperty",
-    "--jscomp_error=deprecated",
-    "--jscomp_error=externsValidation",
-    "--jscomp_error=globalThis",
-    "--jscomp_error=invalidCasts",
-    "--jscomp_error=missingProperties",
-    "--jscomp_error=missingReturn",
-    "--jscomp_error=nonStandardJsDocs",
-    "--jscomp_error=suspiciousCode",
-    "--jscomp_error=undefinedNames",
-    "--jscomp_error=undefinedVars",
-    "--jscomp_error=unknownDefines",
-    "--jscomp_error=uselessCode",
-    "--jscomp_error=visibility",
     "--language_in=ECMASCRIPT5_STRICT",
     "--summary_detail_level=3",
     "--compilation_level=SIMPLE_OPTIMIZATIONS",
     "--source_map_format=V3",
+    "--polymer_pass",
+  ] + ["--jscomp_error=%s" % err for err in _COMMON_JSCOMP_ERRORS] + [
+    "--extra_annotation_name=%s" % a for a in _POLYMER_EXTRA_ANNOTATIONS
   ]

[Dan Beam, 2015/05/12 04:55:55]

make it prettier

] + [
  "--jscomp_error=%s" % err for err in _COMMON_JSCOMP_ERRORS
] + [
  "--extra_annotation_name=%s" % a for a in _POLYMER_EXTRA_ANNOTATIONS
]

OR

_COMMON_JSCOMP_ERRORS = [
  "--jscomp_error=%e" for e in [
    "accessControls",
    ...
  ]
]

# ... later ...

] + _COMMON_JSCOMP_ERRORS + _POLYMER_EXTRA_ANNOTATIONS

[Jeremy Klein, 2015/05/12 05:46:08]

Done.

 
   # These are the extra flags used when compiling in strict mode.
   # Flags that are normally disabled are turned on for strict mode.
   _STRICT_CLOSURE_ARGS = [
     "--jscomp_error=reportUnknownTypes",
     "--jscomp_error=duplicate",
     "--jscomp_error=misplacedTypeAnnotation",
   ]
 
   _DISABLED_CLOSURE_ARGS = [
@@ skipping 13 matching lines @@
   ]
 
   _MAP_FILE_FORMAT = "%s.map"
 
   def __init__(self, verbose=False, strict=False):
     """
     Args:
       verbose: Whether this class should output diagnostic messages.
       strict: Whether the Closure Compiler should be invoked more strictly.
     """
-    current_dir = os.path.join(os.path.dirname(__file__))
-    self._runner_jar = os.path.join(current_dir, "runner", "runner.jar")
+    self._runner_jar = os.path.join(_CURRENT_DIR, "runner", "runner.jar")
     self._temp_files = []
     self._verbose = verbose
     self._strict = strict
     self._error_filter = error_filter.PromiseErrorFilter()
 
   def _nuke_temp_files(self):
     """Deletes any temp files this class knows about."""
     if not self._temp_files:
       return
 
@@ skipping 286 matching lines @@
                       help="Show more information as this script runs")
   parser.add_argument("--strict", action="store_true",
                       help="Enable strict type checking")
   parser.add_argument("--success-stamp",
                       help="Timestamp file to update upon success")
 
   parser.set_defaults(single_file=True, strict=False)
   opts = parser.parse_args()
 
   depends = opts.depends or []
-  externs = opts.externs or set()
+  externs = set(opts.externs) or set()
+
+  polymer_externs = os.path.join(_CURRENT_DIR, os.pardir, 'polymer',

[Dan Beam, 2015/05/12 04:55:55]

hack: if you use os.path.dirname(_CURRENT_DIR) instead of .join(os.pardir) you
can skip the os.path.abspath() call

[Jeremy Klein, 2015/05/12 05:46:08]

Done.

+                                 'v0_8', 'components-chromium',
+                                 'polymer-externs', 'polymer.externs.js')
+  externs.add(os.path.abspath(polymer_externs))
 
   if opts.out_file:
     out_dir = os.path.dirname(opts.out_file)
     if not os.path.exists(out_dir):
       os.makedirs(out_dir)
 
   checker = Checker(verbose=opts.verbose, strict=opts.strict)
   if opts.single_file:
     for source in opts.sources:
       depends, externs = build.inputs.resolve_recursive_dependencies(
           source, depends, externs)
       found_errors, _ = checker.check(source, out_file=opts.out_file,
                                       depends=depends, externs=externs,
                                       output_wrapper=opts.output_wrapper)
       if found_errors:
         sys.exit(1)
   else:
     found_errors, stderr = checker.check_multiple(
         opts.sources,
         out_file=opts.out_file,
         output_wrapper=opts.output_wrapper)
     if found_errors:
       print stderr
       sys.exit(1)
 
   if opts.success_stamp:
     with open(opts.success_stamp, "w"):
       os.utime(opts.success_stamp, None)