Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1112403005: [chrome/browser] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
CC:
chromium-reviews, peter+watch_chromium.org, pam+watch_chromium.org, mlamouri+watch-notifications_chromium.org, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/6a179254d7d55b3987eb4d1a2c64aa5ad1de5d76 Cr-Commit-Position: refs/heads/master@{#328310}

Patch Set 1 #

Patch Set 2 : Fixed nit #

Messages

Total messages: 22 (11 generated)
Pranay
kalman@chromium.org: Please review changes in chrome/browser/apps peter@chromium.org: Please review changes in chrome/browser/notifications blundell@chromium.org: Please review ...
5 years, 7 months ago (2015-05-04 07:08:05 UTC) #2
blundell
blundell -> rogerta
5 years, 7 months ago (2015-05-04 08:46:27 UTC) #4
not at google - send to devlin
apps lgtm
5 years, 7 months ago (2015-05-04 13:53:41 UTC) #5
sky
LGTM
5 years, 7 months ago (2015-05-04 15:29:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112403005/20001
5 years, 7 months ago (2015-05-05 05:30:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112403005/20001
5 years, 7 months ago (2015-05-05 05:51:11 UTC) #11
Bernhard Bauer
lgtm
5 years, 7 months ago (2015-05-05 07:16:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112403005/20001
5 years, 7 months ago (2015-05-05 07:43:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112403005/20001
5 years, 7 months ago (2015-05-05 11:32:08 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-05 11:35:35 UTC) #21
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 11:36:27 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a179254d7d55b3987eb4d1a2c64aa5ad1de5d76
Cr-Commit-Position: refs/heads/master@{#328310}

Powered by Google App Engine
This is Rietveld 408576698