Oilpan: Remove OffHeapCollectionTrait

Source/bindings/scripts/v8_types.py

Index: Source/bindings/scripts/v8_types.py
diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py
index 512e324aa64bc40c5447600dc3f822a650787a49..5e8a45aad46f67fd4d5df1ced2e418bff463a361 100644
--- a/Source/bindings/scripts/v8_types.py
+++ b/Source/bindings/scripts/v8_types.py
@@ -310,7 +310,7 @@ IdlType.set_will_be_garbage_collected_types = classmethod(
 
 
 def gc_type(idl_type):
-    if idl_type.is_garbage_collected:
+    if idl_type.is_garbage_collected or idl_type.is_dictionary:

[bashi, 2015/05/01 04:31:23]

Shouldn't we also add is_union_type?

(It sounds a bit strange because dictionaries are not garbage collected object,
but it's not refcounted object too, so it would be fine)

[haraken, 2015/05/01 05:34:11]

Yeah, that's confusing. "GarbageCollectedObject" here means objects that need
tracing (not objects that derive GarbageCollected). So it makes sense to make
dictionaries and union types "GarbageCollectedObject".

[haraken, 2015/05/01 05:34:11]

Regarding union types, I noticed that it's (already) buggy in a couple of ways.
Let me address the issue in a separate CL.

         return 'GarbageCollectedObject'
     if idl_type.is_will_be_garbage_collected:
         return 'WillBeGarbageCollectedObject'
@@ -590,6 +590,10 @@ def v8_value_to_cpp_value_array_or_sequence(native_array_element_type, v8_value,
         this_cpp_type = None
         ref_ptr_type = cpp_ptr_type('RefPtr', 'Member', native_array_element_type.gc_type)
         expression_format = '(to{ref_ptr_type}NativeArray<{native_array_element_type}, V8{native_array_element_type}>({v8_value}, {index}, {isolate}, exceptionState))'
+    elif native_array_element_type.is_dictionary:

[bashi, 2015/05/01 04:31:23]

Same for native_array_element_type.is_union_type ?

+        ref_ptr_type = None
+        this_cpp_type = native_array_element_type.cpp_type
+        expression_format = 'toImplHeapArray<{cpp_type}>({v8_value}, {index}, {isolate}, exceptionState)'
     else:
         ref_ptr_type = None
         this_cpp_type = native_array_element_type.cpp_type