Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1112343004: PPC: Resolve references to "this" the same way as normal variables (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Resolve references to "this" the same way as normal variables Port 18619d355192e2699203d12d9ebb9caea107b693 Original commit message: Make the parser handle references to "this" as unresolved variables, so the same logic as for the rest of function parameters is used for the receiver. Minor additions to the code generation handle copying the receiver to the context, along with the rest of the function parameters. Based on work by Adrian Perez de Castro <aperez@igalia.com>;. R=wingo@igalia.com, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/ppc/full-codegen-ppc.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-05 17:29:24 UTC) #1
dstence
lgtm
5 years, 7 months ago (2015-05-05 17:38:42 UTC) #2
arv (Not doing code reviews)
FYI, The original CL was reverted
5 years, 7 months ago (2015-05-05 18:08:27 UTC) #3
MTBrandyberry
5 years, 7 months ago (2015-05-05 18:11:15 UTC) #4
On 2015/05/05 18:08:27, arv wrote:
> FYI, The original CL was reverted

Thanks.  Holding off for now.

Powered by Google App Engine
This is Rietveld 408576698