Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1112343002: [test] Remove DirectGraphBuilder helper. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-test-machine-call-helper
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove DirectGraphBuilder helper. R=bmeurer@chromium.org TEST=cctest/test-js-context-specialization Committed: https://crrev.com/00639c7511356bf0ba50f7f1e990013957c24117 Cr-Commit-Position: refs/heads/master@{#28160}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -49 lines) Patch
M test/cctest/compiler/graph-builder-tester.h View 1 1 chunk +0 lines, -15 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 9 chunks +38 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 7 months ago (2015-04-30 10:59:02 UTC) #1
Benedikt Meurer
lgtm
5 years, 7 months ago (2015-04-30 10:59:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112343002/20001
5 years, 7 months ago (2015-04-30 11:37:55 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-30 12:06:25 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 12:06:42 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00639c7511356bf0ba50f7f1e990013957c24117
Cr-Commit-Position: refs/heads/master@{#28160}

Powered by Google App Engine
This is Rietveld 408576698