Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1112333002: [content/browser/media] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, Pranay
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in content/browser/media module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/07f0d74ab9b57a7a7aa28c035a0133b0fca2e3e2 Cr-Commit-Position: refs/heads/master@{#328285}

Patch Set 1 #

Patch Set 2 : Fixed build break #

Total comments: 6

Patch Set 3 : Fixed comments #

Patch Set 4 : Fiexd nit #

Patch Set 5 : Fixed build break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M content/browser/media/android/media_drm_credential_manager.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/media/capture/web_contents_audio_input_stream_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/media/capture/web_contents_tracker.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/media/capture/web_contents_tracker.cc View 1 2 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-04-30 12:07:42 UTC) #2
xhwang
Thanks! Just a few comments. https://codereview.chromium.org/1112333002/diff/20001/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc File content/browser/media/capture/web_contents_audio_input_stream_unittest.cc (right): https://codereview.chromium.org/1112333002/diff/20001/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc#newcode11 content/browser/media/capture/web_contents_audio_input_stream_unittest.cc:11: #include "base/message_loop/message_loop.h" Do we ...
5 years, 7 months ago (2015-04-30 15:54:45 UTC) #3
anujsharma
Thanks xhwang for your comments!! I have made the changes. Could you please take a ...
5 years, 7 months ago (2015-05-04 08:07:56 UTC) #4
xhwang
lgtm
5 years, 7 months ago (2015-05-04 16:13:03 UTC) #5
anujsharma
On 2015/05/04 16:13:03, xhwang wrote: > lgtm Thanks xhwang for lgtm.
5 years, 7 months ago (2015-05-04 16:39:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112333002/60001
5 years, 7 months ago (2015-05-04 16:40:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_android/builds/6932)
5 years, 7 months ago (2015-05-04 17:07:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112333002/80001
5 years, 7 months ago (2015-05-05 04:29:54 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-05 05:34:56 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 05:36:43 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/07f0d74ab9b57a7a7aa28c035a0133b0fca2e3e2
Cr-Commit-Position: refs/heads/master@{#328285}

Powered by Google App Engine
This is Rietveld 408576698