Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1112193002: Change the print format to be unsigned int (Closed)

Created:
5 years, 7 months ago by lanwei
Modified:
5 years, 7 months ago
CC:
chromium-reviews, jam, jdduke+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the print format to be unsigned int, since the variable is uint32. BUG=466711 NOTREECHECKS=true Committed: https://crrev.com/faa46811677cfe1c7356a131628d3ad400e156aa Cr-Commit-Position: refs/heads/master@{#327551}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/common/input/web_input_event_traits.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
lanwei
Could you please take a look? Thank you.
5 years, 7 months ago (2015-04-29 18:28:50 UTC) #2
jdduke (slow)
On 2015/04/29 18:28:50, lanwei wrote: > Could you please take a look? > > Thank ...
5 years, 7 months ago (2015-04-29 18:31:01 UTC) #3
jdduke (slow)
https://codereview.chromium.org/1112193002/diff/1/content/common/input/web_input_event_traits.cc File content/common/input/web_input_event_traits.cc (right): https://codereview.chromium.org/1112193002/diff/1/content/common/input/web_input_event_traits.cc#newcode116 content/common/input/web_input_event_traits.cc:116: event.uniqueTouchEventId); we may need to make this: static_cast<uint32>(event.uniqueTouchEventId) to ...
5 years, 7 months ago (2015-04-29 18:33:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112193002/1
5 years, 7 months ago (2015-04-29 18:37:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112193002/20001
5 years, 7 months ago (2015-04-29 18:42:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112193002/20001
5 years, 7 months ago (2015-04-29 20:13:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-29 20:14:29 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 20:15:33 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/faa46811677cfe1c7356a131628d3ad400e156aa
Cr-Commit-Position: refs/heads/master@{#327551}

Powered by Google App Engine
This is Rietveld 408576698