Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1112153002: Use explicit DOM cast template for presentationalRole handling. (Closed)

Created:
5 years, 7 months ago by je_julie(Not used)
Modified:
5 years, 7 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use explicit DOM cast template for presentationalRole handling. This patch refines the current presentation handling as using explicit cast template and renaming parameters and functions at isRequiredOwnedElement() and isPresentationalInTable(). BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M Source/modules/accessibility/AXNodeObject.cpp View 4 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
je_julie(Not used)
Hi Dominic, This path refines the current presentation handling. 1) Uses explicit DOM cast template. ...
5 years, 7 months ago (2015-04-29 23:20:59 UTC) #2
dmazzoni
lgtm
5 years, 7 months ago (2015-04-29 23:26:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112153002/1
5 years, 7 months ago (2015-04-29 23:27:09 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 02:23:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194693

Powered by Google App Engine
This is Rietveld 408576698