Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1112113002: Show function <name>() { [native code] } for built-in classes (Closed)

Created:
5 years, 7 months ago by domenic
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Show function <name>() { [native code] } for built-in classes The existing logic would show the full source for all classes, even built-in ones. R=arv@chromium.org,dslomov@chromium.org BUG= Committed: https://crrev.com/a34bbef3146902e5268ce899444cf011b501b300 Cr-Commit-Position: refs/heads/master@{#28151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M src/v8natives.js View 2 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
domenic
5 years, 7 months ago (2015-04-29 14:12:33 UTC) #1
arv (Not doing code reviews)
Can this be tested? At first I wasn't sure using function would be better than ...
5 years, 7 months ago (2015-04-29 15:05:02 UTC) #2
domenic
On 2015/04/29 at 15:05:02, arv wrote: > Can this be tested? Not easily ... right ...
5 years, 7 months ago (2015-04-29 15:15:42 UTC) #3
Dmitry Lomov (no reviews)
lgtm
5 years, 7 months ago (2015-04-30 08:47:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112113002/1
5 years, 7 months ago (2015-04-30 09:06:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 09:29:38 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 09:29:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a34bbef3146902e5268ce899444cf011b501b300
Cr-Commit-Position: refs/heads/master@{#28151}

Powered by Google App Engine
This is Rietveld 408576698