Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1112073002: Destructuring: add more pasring tests. (Closed)

Created:
5 years, 7 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Destructuring: add more parssing tests. R=arv@chromium.org BUG=v8:811 LOG=N Committed: https://crrev.com/cec53692d17f21374fbd2df1fcef6f60adf7dd96 Cr-Commit-Position: refs/heads/master@{#28131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/cctest/test-parsing.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dmitry Lomov (no reviews)
PTAL
5 years, 7 months ago (2015-04-29 09:36:25 UTC) #1
arv (Not doing code reviews)
lgtm
5 years, 7 months ago (2015-04-29 12:20:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112073002/1
5 years, 7 months ago (2015-04-29 12:21:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 13:03:32 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 13:03:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cec53692d17f21374fbd2df1fcef6f60adf7dd96
Cr-Commit-Position: refs/heads/master@{#28131}

Powered by Google App Engine
This is Rietveld 408576698