Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 11120002: [Mac] Do not post NSApplicationWillTerminateNotification via a task, do it immediately. (Closed)

Created:
8 years, 2 months ago by Robert Sesek
Modified:
8 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Do not post NSApplicationWillTerminateNotification via a task, do it immediately. BUG=155318, 153283 TEST=Crash server numbers. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161578

Patch Set 1 #

Patch Set 2 : Need logging.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M chrome/browser/lifetime/application_lifetime_mac.mm View 1 1 chunk +5 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
8 years, 2 months ago (2012-10-12 14:53:24 UTC) #1
Scott Hess - ex-Googler
lgtm, but it might be nice to have a description of the termination workflow somewhere.
8 years, 2 months ago (2012-10-12 15:12:56 UTC) #2
Robert Sesek
On 2012/10/12 15:12:56, shess wrote: > lgtm, but it might be nice to have a ...
8 years, 2 months ago (2012-10-12 15:13:58 UTC) #3
Scott Hess - ex-Googler
On 2012/10/12 15:13:58, rsesek wrote: > On 2012/10/12 15:12:56, shess wrote: > > lgtm, but ...
8 years, 2 months ago (2012-10-12 15:22:09 UTC) #4
Mark Mentovai
8 years, 2 months ago (2012-10-12 15:37:27 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698