Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1111953003: mac: Rename the method -accessibilityChildren on TabStripView. (Closed)

Created:
5 years, 7 months ago by erikchen
Modified:
5 years, 7 months ago
Reviewers:
Mark Mentovai, Andre
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Rename the method -accessibilityChildren on TabStripView. The method -accessibilityChildren was introduced in the NSAccessibilityLayoutArea protocol in Yosemite. To avoid confusion, I renamed the method on TabStripView to tabStripViewAccessibilityChildren. BUG=471823 Committed: https://crrev.com/b191b3a454a73b6a224ed1f6e828e3389cae6666 Cr-Commit-Position: refs/heads/master@{#327534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_view.mm View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
erikchen
andresantoso: Please review. Alternatively, we could declare the method in a private category in tab_strip_view.mm. ...
5 years, 7 months ago (2015-04-28 23:59:10 UTC) #2
Andre
lgtm
5 years, 7 months ago (2015-04-29 00:12:38 UTC) #3
erikchen
mark: Looking for an OWNER review.
5 years, 7 months ago (2015-04-29 18:00:39 UTC) #5
Mark Mentovai
LGTM
5 years, 7 months ago (2015-04-29 18:01:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111953003/1
5 years, 7 months ago (2015-04-29 18:03:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 19:04:33 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 19:05:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b191b3a454a73b6a224ed1f6e828e3389cae6666
Cr-Commit-Position: refs/heads/master@{#327534}

Powered by Google App Engine
This is Rietveld 408576698