Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1111923002: Remove unnecessary ScopedTrackers from ProxyScript code. (Closed)

Created:
5 years, 7 months ago by eroman
Modified:
5 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary ScopedTrackers from ProxyScript code. BUG=455942 Committed: https://crrev.com/1506371212005350b93213eaa9e4540e0fc4529b Cr-Commit-Position: refs/heads/master@{#327406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
M net/proxy/proxy_script_decider.cc View 9 chunks +0 lines, -39 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 4 chunks +0 lines, -15 lines 0 comments Download
M net/proxy/proxy_service.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eroman
5 years, 7 months ago (2015-04-28 22:33:21 UTC) #2
Peter Kasting
LGTM, you can TBR this sort of thing
5 years, 7 months ago (2015-04-28 22:34:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111923002/1
5 years, 7 months ago (2015-04-28 22:37:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 00:59:06 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 00:59:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1506371212005350b93213eaa9e4540e0fc4529b
Cr-Commit-Position: refs/heads/master@{#327406}

Powered by Google App Engine
This is Rietveld 408576698