Issue 1111913003: toolchain_build: Avoid python tracebacks for package build errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1111913003: toolchain_build: Avoid python tracebacks for package build errors (Closed)

Created:
5 years, 7 months ago by Derek Schuff

Modified:
5 years, 7 months ago

Reviewers:
bradn

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

toolchain_build: Avoid python tracebacks for package build errors Handle CalledProcessError and print an error message including the name of the failing package rather than a generic traceback. BUG=none R=bradnelson@google.com Committed: https://chromium.googlesource.com/native_client/src/native_client/+/336e9dd967b8aa8dfe5435ab27a4c4c373b567f8

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -9 lines)			Patch
M	toolchain_build/toolchain_build.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	toolchain_build/toolchain_build_pnacl.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	toolchain_build/toolchain_main.py	View	8 chunks	+20 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

Derek Schuff

5 years, 7 months ago (2015-04-29 20:04:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
336e9dd967b8aa8dfe5435ab27a4c4c373b567f8 (presubmit successful).