Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1111913002: vs2015: avoid narrowing warning in plugin_service_impl (Closed)

Created:
5 years, 7 months ago by scottmg
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-v8
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

vs2015: avoid narrowing warning in plugin_service_impl [171->263/443 ~9] CXX obj\content\browser\content_browser.plugin_service_impl.obj FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\cl.exe" /nologo /showIncludes /FC @obj\content\browser\content_browser.plugin_service_impl.obj.rsp /c ..\..\content\browser\plugin_service_impl.cc /Foobj\content\browser\content_browser.plugin_service_impl.obj /Fdobj\content\content_browser.cc.pdb d:\src\cr2\src\content\browser\plugin_service_impl.cc(842): error C2220: warning treated as error - no 'object' file generated d:\src\cr2\src\content\browser\plugin_service_impl.cc(842): warning C4302: 'reinterpret_cast': truncation from 'HANDLE' to 'ATOM' R=jam@chromium.org BUG=440500 Committed: https://crrev.com/4800fc26e63ee53d9c1532e1519c738a85f34f86 Cr-Commit-Position: refs/heads/master@{#327403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/plugin_service_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
scottmg
5 years, 7 months ago (2015-04-28 20:11:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111913002/1
5 years, 7 months ago (2015-04-28 20:12:22 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-28 21:26:33 UTC) #6
jam
lgtm
5 years, 7 months ago (2015-04-29 00:24:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111913002/1
5 years, 7 months ago (2015-04-29 00:29:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 00:31:26 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 00:32:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4800fc26e63ee53d9c1532e1519c738a85f34f86
Cr-Commit-Position: refs/heads/master@{#327403}

Powered by Google App Engine
This is Rietveld 408576698