Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: content/common/gpu/media/dxva_video_decode_accelerator.h

Issue 1111903002: win: Move DXVAVideoDecodeAccelerator's WeakPtrFactory member to the end. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/gpu/media/dxva_video_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/media/dxva_video_decode_accelerator.h
diff --git a/content/common/gpu/media/dxva_video_decode_accelerator.h b/content/common/gpu/media/dxva_video_decode_accelerator.h
index 0cb9afb52fb863cd90cc60f8fbabee5df1eed0b6..918531dc988f1b687c172d75611bc2053a476c80 100644
--- a/content/common/gpu/media/dxva_video_decode_accelerator.h
+++ b/content/common/gpu/media/dxva_video_decode_accelerator.h
@@ -343,14 +343,11 @@ class CONTENT_EXPORT DXVAVideoDecodeAccelerator
// Used to synchronize access between the decoder thread and the main thread.
base::Lock decoder_lock_;
- // WeakPtrFactory for posting tasks back to |this|.
- base::WeakPtrFactory<DXVAVideoDecodeAccelerator> weak_this_factory_;
-
// Disallow rebinding WeakReference ownership to a different thread by
// keeping a persistent reference. This avoids problems with the
// thread safety of reaching into this class from multiple threads to
// attain a WeakPtr.
- const base::WeakPtr<DXVAVideoDecodeAccelerator> weak_ptr_;
+ base::WeakPtr<DXVAVideoDecodeAccelerator> weak_ptr_;
// Set to true if we are in the context of a Flush operation. Used to prevent
// multiple flush done notifications being sent out.
@@ -367,6 +364,9 @@ class CONTENT_EXPORT DXVAVideoDecodeAccelerator
// The GLContext to be used by the decoder.
scoped_refptr<gfx::GLContext> gl_context_;
+ // WeakPtrFactory for posting tasks back to |this|.
+ base::WeakPtrFactory<DXVAVideoDecodeAccelerator> weak_this_factory_;
+
// Function pointer for the MFCreateDXGIDeviceManager API.
static CreateDXGIDeviceManager create_dxgi_device_manager_;
};
« no previous file with comments | « no previous file | content/common/gpu/media/dxva_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698