Issue 1111893002: small refactor: use JS.* prefix for our other JS extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1111893002: small refactor: use JS.* prefix for our other JS extensions (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly

Modified:
5 years, 7 months ago

Reviewers:
Jacob

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

small refactor: use JS.* prefix for our other JS extensions it's not clear what will end up in js_ast vs ddc, so nice to use js_ast conventions for the JS nodes R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/0badd5112956cdfba6eb9a835a71fc8d3ffbef96

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -40 lines)			Patch
M	lib/src/codegen/js_codegen.dart	View	11 chunks	+16 lines, -16 lines	0 comments	Download
M	lib/src/codegen/js_metalet.dart	View	10 chunks	+10 lines, -10 lines	0 comments	Download
M	lib/src/codegen/js_names.dart	View	5 chunks	+10 lines, -10 lines	0 comments	Download
M	lib/src/codegen/js_printer.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	lib/src/utils.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 7 months ago (2015-04-29 21:41:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0badd5112956cdfba6eb9a835a71fc8d3ffbef96 (presubmit successful).