Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1111873002: android_webview: don't suppress debuggerd crash handling. (Closed)

Created:
5 years, 7 months ago by Torne
Modified:
5 years, 7 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/branch-heads/2357
Project:
chromium
Visibility:
Public.

Description

android_webview: don't suppress debuggerd crash handling. WebView was incorrectly suppressing debuggerd crash handling after breakpad microdumps were triggered on all user builds of android, as the process type was not empty as expected for the Chrome browser process. This went unnoticed as the normal behaviour was still in place for userdebug/eng builds. Fix by also treating "webview" process type as a browser process in the crash component. BUG=481420 Review URL: https://codereview.chromium.org/1105293003 Cr-Commit-Position: refs/heads/master@{#327277} (cherry picked from commit 5db4beded0f78f77207790cd9a66bf7fcbfc4fc3) Committed: https://chromium.googlesource.com/chromium/src/+/bd67cb98f8ce063c4f71f252093038cbe3ae06d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/crash/app/breakpad_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Torne
5 years, 7 months ago (2015-04-28 17:20:13 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd67cb98f8ce063c4f71f252093038cbe3ae06d1.

Powered by Google App Engine
This is Rietveld 408576698