Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 111183004: win: Use ninja by default (Closed)

Created:
6 years, 11 months ago by scottmg
Modified:
6 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

win: Use ninja by default With this change, `gclient runhooks` creates ninja files by default on Windows. To build, run `ninja -C out\Release chrome`. The output appears in out\ instead of build\. If you need to use a VS build for some reason, you can still `set GYP_GENERATORS=msvs`. This is no longer a tested configuration. Bots should automatically pick up the binaries in the new location (out). If something does break, it should be safe to revert this change, and bots should then automatically go back to picking up binaries from the old location (build). R=thakis@chromium.org BUG=303291 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/gyp_chromium View 1 chunk +4 lines, -1 line 0 comments Download
M build/landmine_utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
As mentioned, the trybots are useless, but I guess they check the code is syntactically ...
6 years, 11 months ago (2014-01-07 18:17:01 UTC) #1
Nico
lgtm I was idly thinking about adding a win_msvs trybot that uses msvs so that ...
6 years, 11 months ago (2014-01-07 18:43:45 UTC) #2
scottmg
6 years, 11 months ago (2014-01-09 05:08:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r243782 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698