Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 111183002: Include VS2013 runtime folders in PATH for automatic toolchain (Closed)

Created:
7 years ago by scottmg
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Include VS2013 runtime folders in PATH for automatic toolchain Reproduced on a new Win7 x64 VM, and this fixed the build (at least for the chrome target). This doesn't address the need to copy the runtime DLLs into the output directory so that chrome runs though, that's a separate problem where something in chrome's gyp should be copying them there, at least for a debug build. TBR=mikelawther@chromium.org BUG=326345 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/gyp_chromium View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
7 years ago (2013-12-10 05:28:29 UTC) #1
scottmg
Committed patchset #1 manually as r239671 (presubmit successful).
7 years ago (2013-12-10 05:34:11 UTC) #2
Mike Lawther (Google)
7 years ago (2013-12-10 06:47:51 UTC) #3
Message was sent while issue was closed.
lgtm. As I commented on the bug:

"I updated past r239671 (my checkout is now at r239683), and following my steps
in the OP now produces a working Release compile and build of content_shell.exe.
Yay!"

Powered by Google App Engine
This is Rietveld 408576698