[iOS] Pack ios_strings_resources_${locale}.pak files

[iOS] Pack ios_strings_resources_${locale}.pak files

Add ios/chrome/ios_strings_resources_${locale}.pak files to the
repack_locales.py script and "packed_resources" target.

BUG=475514
Committed: https://crrev.com/afeb5b7e031be63f2c512d5caea62d492fd30ba9
Cr-Commit-Position: refs/heads/master@{#327524}

[sdefresne, 2015-04-28 15:11:01]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-28 15:11:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1111823002/1

[sdefresne, 2015-04-28 15:11:54]

sdefresne@chromium.org changed reviewers:
+ thakis@chromium.org

[sdefresne, 2015-04-28 15:11:54]

Can you review?

[sdefresne, 2015-04-28 15:12:40]

sdefresne@chromium.org changed reviewers:
+ kerz@chromium.org

[sdefresne, 2015-04-28 15:12:40]

+kerz@chromium.org as OWNERS of chrome/tools/build

[kerz_chromium, 2015-04-28 15:14:23]

kerz@chromium.org changed reviewers:
+ amineer@chromium.org, pennymac@chromium.org

[kerz_chromium, 2015-04-28 15:14:23]

Adding Alex and Penny just in case something goes south here.

LGTM

[commit-bot: I haz the power, 2015-04-28 16:03:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 16:03:06]

Dry run: This issue passed the CQ dry run.

[Nico, 2015-04-28 18:07:34]

lgtm, but I don't understand why the line i commented on got changed

https://codereview.chromium.org/1111823002/diff/1/chrome/chrome_resources.gyp
File chrome/chrome_resources.gyp (left):

https://codereview.chromium.org/1111823002/diff/1/chrome/chrome_resources.gyp...
chrome/chrome_resources.gyp:455: }, {  # else
why this change?

[sdefresne, 2015-04-29 07:36:24]

Thank you for the review.

As the CL has been l-g-t-m-ed I'm going to land it as is by EOD. If you want me
to change back the code to use "else" block instead I'll do it in a followup CL
if my CL lands before your comment.

https://codereview.chromium.org/1111823002/diff/1/chrome/chrome_resources.gyp
File chrome/chrome_resources.gyp (left):

https://codereview.chromium.org/1111823002/diff/1/chrome/chrome_resources.gyp...
chrome/chrome_resources.gyp:455: }, {  # else
On 2015/04/28 18:07:34, Nico wrote:
> why this change?

When editing gyp files, I find "else" block in condition really hard to find.
Here I was looking for 'OS == "ios"' block and could not find it so added a new
one, and then later found this "else" and merged them.

BTW, I'm probably not the only one to find "else" hard to understand since the
original code retested the same condition (that second test was useless) inside
the else block as you can see below. I think that removing the else and adding a
new 'OS == "ios"' block explicitly make it the code easier to read and update.

[sdefresne, 2015-04-29 15:27:53]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-04-29 15:28:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1111823002/1

[Nico, 2015-04-29 15:33:16]

https://codereview.chromium.org/1111823002/diff/1/chrome/chrome_resources.gyp
File chrome/chrome_resources.gyp (left):

https://codereview.chromium.org/1111823002/diff/1/chrome/chrome_resources.gyp...
chrome/chrome_resources.gyp:455: }, {  # else
I find the new spelling very confusing. Please keep this as it was (in this
change, not in a follow-up).

[Nico, 2015-04-29 15:33:23]

The CQ bit was unchecked by thakis@chromium.org

[sdefresne, 2015-04-29 16:26:31]

Patchset #2 (id:20001) has been deleted

[sdefresne, 2015-04-29 16:26:59]

I've used the old syntax, can you take another look thakis?

https://codereview.chromium.org/1111823002/diff/1/chrome/chrome_resources.gyp
File chrome/chrome_resources.gyp (left):

https://codereview.chromium.org/1111823002/diff/1/chrome/chrome_resources.gyp...
chrome/chrome_resources.gyp:455: }, {  # else
On 2015/04/29 15:33:16, Nico wrote:
> I find the new spelling very confusing. Please keep this as it was (in this
> change, not in a follow-up).

Sure. Done.

[sdefresne, 2015-04-29 17:52:14]

BTW, could you please tick the CQ if patchset 2 looks good?

[Nico, 2015-04-29 18:04:10]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-04-29 18:04:11]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
kerz@chromium.org
Link to the patchset: https://codereview.chromium.org/1111823002/#ps40001
(title: "Address thakis comment")

[commit-bot: I haz the power, 2015-04-29 18:04:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1111823002/40001

[commit-bot: I haz the power, 2015-04-29 18:11:55]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-04-29 18:12:43]

Patchset 2 (id:??) landed as
https://crrev.com/afeb5b7e031be63f2c512d5caea62d492fd30ba9
Cr-Commit-Position: refs/heads/master@{#327524}