Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 11118018: Enable --verify-heap in release mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by mvstanton
Modified:
2 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -468 lines) Patch
M Makefile View 1 chunk +4 lines, -0 lines 0 comments Download
M build/common.gypi View 3 chunks +10 lines, -4 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/assembler.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/heap.h View 4 chunks +19 lines, -6 lines 0 comments Download
M src/heap.cc View 21 chunks +43 lines, -31 lines 0 comments Download
M src/heap-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/incremental-marking.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mark-compact.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mark-compact.cc View 13 chunks +18 lines, -14 lines 0 comments Download
M src/objects.h View 67 chunks +82 lines, -189 lines 0 comments Download
M src/objects.cc View 4 chunks +22 lines, -8 lines 0 comments Download
M src/objects-debug.cc View 19 chunks +99 lines, -113 lines 0 comments Download
M src/objects-inl.h View 5 chunks +10 lines, -14 lines 0 comments Download
M src/runtime.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/spaces.h View 6 chunks +21 lines, -14 lines 0 comments Download
M src/spaces.cc View 16 chunks +55 lines, -46 lines 0 comments Download
M src/store-buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/store-buffer.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 1 chunk +2 lines, -1 line 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
mvstanton
2 years, 5 months ago (2012-10-12 11:30:48 UTC) #1
Michael Starzinger
2 years, 5 months ago (2012-10-12 11:32:12 UTC) #2
LGTM. This is just a re-upload of a different CL that was already thoroughly
reviewed. It only fixes the account.

Original CL: https://codereview.chromium.org/11085070/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d