src/utils.cc - Issue 1111733002: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils.cc

Issue 1111733002: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix Win warnings. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/utils.cc

diff --git a/src/utils.cc b/src/utils.cc

index c6fe55b5c65d309c190ff3bd3568247c5dc7774f..b33e4c2de3b63dd4a487f9dd10f616003bbfcfcf 100644

--- a/src/utils.cc

+++ b/src/utils.cc

@@ -203,7 +203,7 @@ char* ReadCharsFromFile(FILE* file,

}

// Get the size of the file and rewind it.

- *size = ftell(file);

+ *size = static_cast<int>(ftell(file));

rewind(file);

char* result = NewArray<char>(*size + extra_space);

« no previous file with comments | « src/snapshot/mksnapshot.cc ('k') | test/cctest/compiler/call-tester.h » ('j') | no next file with comments »