src/flags.cc - Issue 1111733002: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flags.cc

Issue 1111733002: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix Win warnings. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/flags.cc

diff --git a/src/flags.cc b/src/flags.cc

index 7386238090237386154987c7c3c86a89d48d7b68..88f06a301c626cd9d0104e5dc1278f5c52816d80 100644

--- a/src/flags.cc

+++ b/src/flags.cc

@@ -394,7 +394,7 @@ int FlagList::SetFlagsFromCommandLine(int* argc,

*flag->maybe_bool_variable() = MaybeBoolFlag::Create(true, !is_bool);

break;

case Flag::TYPE_INT:

- *flag->int_variable() = strtol(value, &endp, 10); // NOLINT

+ *flag->int_variable() = static_cast<int>(strtol(value, &endp, 10));

break;

case Flag::TYPE_FLOAT:

*flag->float_variable() = strtod(value, &endp);

« no previous file with comments | « src/d8-posix.cc ('k') | src/gdb-jit.cc » ('j') | no next file with comments »